fix(build): add path-with-spaces check and document ARM64 dev container support#10048
Open
shiavm006 wants to merge 1 commit intostdlib-js:developfrom
Open
fix(build): add path-with-spaces check and document ARM64 dev container support#10048shiavm006 wants to merge 1 commit intostdlib-js:developfrom
shiavm006 wants to merge 1 commit intostdlib-js:developfrom
Conversation
shiavm006
force-pushed
the
fix/dev-environment-blockers
branch
from
279b370 to
c270df1
Compare
Contributor
Author
|
cc @kgryte |
shiavm006
changed the title
…er support Add early failure when project directory path contains spaces, as GNU make and shell scripts fail in such environments. Update documentation to state that the dev container now supports ARM64/Apple Silicon architectures. Add required usage/examples sections to FAQ and setting_up_a_devcontainer to satisfy markdown linter. Fix devcontainer-setup link in FAQ.
shiavm006
force-pushed
the
fix/dev-environment-blockers
branch
from
de62075 to
92b3053
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4934.
Description
This pull request:
mcr.microsoft.com/devcontainers/javascript-node:1-22-bookwormimage is multi-arch and works on both x86_64 and ARM64.Related Issues
This pull request has the following related issues:
Questions
No.
Other
The path check uses a simple
findstringtest for spaces inROOT_DIRand runs at Makefile parse time, so it applies to all make targets. The error message directs users to move the repository to a path without spaces (e.g.,stdlib_gsocinstead ofstdlib gsoc).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
N/A
@stdlib-js/reviewers